[wp-trac] [WordPress Trac] #43344: $wp_locale->start_of_week is always NULL

[WordPress Trac]

#43344: $wp_locale->start_of_week is always NULL
------------------------------------+------------------------------
 Reporter:  tonybogdanov            |       Owner:
     Type:  defect (bug)            |      Status:  closed
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  I18N                    |     Version:  4.4
 Severity:  minor                   |  Resolution:  invalid
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+------------------------------
Changes (by birgire):

 * keywords:  dev-feedback => dev-feedback has-patch
 * status:  new => closed
 * focuses:  coding-standards =>
 * resolution:   => invalid


Comment:

 Nice findings @tonybogdanov

 I did some digging:

 This was introduced in changeset [35336] for the ticket ''Remove "Week
 Starts On" setting UI'' #28344.

 That ticket was then closed with a ''wontfix'' with new code additions
 reverted in changeset [35685], but the newly added property definition:

 {{{
 /**
  * Stores the default start of the week.
  *
  * @since 4.4.0
  * @var string
  */
  public $start_of_week;

 }}}

 was not reverted as expected.

 So I would suggest to remove it, from the {{{WP_Locale}}} class, as it's
 not used anywhere and should have been removed in [35685].

 This part is removed in [attachment:43344.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43344#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform