[wp-trac] [WordPress Trac] #43055: Reorganize Core JS / introduce build step

WordPress Trac noreply at wordpress.org
Wed Feb 14 02:59:38 UTC 2018


#43055: Reorganize Core JS / introduce build step
------------------------------+-------------------------
 Reporter:  omarreiss         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  dev-feedback      |     Focuses:  javascript
------------------------------+-------------------------

Comment (by netweb):

 Some notes regarding [attachment:js-organization-2.patch]:

 Firstly which this relates to the first bullet point coming up, can
 [https://github.com/Yoast/wordpress-develop-mirror/tree/fresh-js-src-move
 the branch] for [attachment:js-organization-2.patch] be updated from
 `master`/`/trunk`? (FYI: I'm not sure if there are potentially other
 issues caused by this)

 * `package.json` is since [42460] indented using tabs (The new `package-
 lock.json` file will need to be regenerated after this is fixed and will
 then inherit the tabbed indentation)

 * `jquery-color`, was there a reason to choose v2.1.1 over the latest 2.x
 branch v2.1.2? ([https://github.com/jquery/jquery-
 color/compare/2.1.1...2.1.2 comparison here]). It also looks like they are
 resolving the issue of the package not being published to npm in
 [https://github.com/jquery/jquery-color/issues/84 jquery/jquery-
 color/issues/84]

 * `jquery-ui`, was there a reason to choose v1.11.4 over the latest
 c1.12.1 which is published to npm? ([https://github.com/jquery/jquery-
 ui/compare/1.11.4...1.12.1 comparison here])

 Pausing my review here... @omarreiss Would you prefer comments
 [https://github.com/Yoast/wordpress-develop-mirror/pull/97 on the PR]? I
 think that might be a little easier to manage feedback?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43055#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list