[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions
WordPress Trac
noreply at wordpress.org
Fri Feb 9 16:22:53 UTC 2018
#41191: Create browse happy type notice for PHP versions
--------------------------------------+-----------------------
Reporter: joostdevalk | Owner: flixos90
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.0
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------
Changes (by flixos90):
* keywords: => has-patch has-unit-tests
* owner: schlessera => flixos90
* milestone: 4.9.5 => 5.0
Comment:
I'm not opposed to the alternative approach @nerrad suggests, but I think
an admin notice is the most straightforward and on-point solution here.
Per the discussion on Slack, let's rather aim for 5.0 instead of a minor
release, as seeing the notice after a minor release may indeed feel weird.
[attachment:41191.2.diff] simply adjusts the version numbers accordingly.
Per the suggestion by @clorith, we should also consider using a warning
color for the notice. While each of us probably considers a site running
PHP 5.2 "broken", we have to be honest to ourselves: It is not broken. It
is insecure and all sorts of other things, but I think a warning actually
fits better.
Again, please continue further discussion [on GitHub](https://github.com
/wp-core-php/wordpress-develop/pull/1).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list