[wp-trac] [WordPress Trac] #43230: JSDoc: wp-includes/js/media/views/spinner.js
WordPress Trac
noreply at wordpress.org
Fri Feb 9 14:31:08 UTC 2018
#43230: JSDoc: wp-includes/js/media/views/spinner.js
--------------------------+------------------------------
Reporter: avillegasn | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: docs javascript
--------------------------+------------------------------
Comment (by atimmer):
Thank you for your contribution!
As far as I could see the Spinner was introduced in this commit:
https://github.com/WordPress/wordpress-
develop/commit/15533d1d1fc6c249ac3b99be8b30234463b6ced3. The first release
that was in was 3.9.0, so I changed to `@since` tags.
`@access public` is not necessary because this is the default access. I've
also added a comment about the delay that's in the show method. This helps
people understand the code.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43230#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list