[wp-trac] [WordPress Trac] #37392: Multisite "Sites" screen: Add links to filter websites by status

[WordPress Trac]

#37392: Multisite "Sites" screen: Add links to filter websites by status
----------------------------------------+------------------------
 Reporter:  thomaswm                    |       Owner:  mnelson4
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:
Component:  Networks and Sites          |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------
Changes (by mnelson4):

 * keywords:  has-patch needs-unit-tests 2nd-opinion => has-patch needs-
     unit-tests


Comment:

 Ok I think the latest patch applies your suggestions @flixos90 (the
 previous ones did too, but had formatting mistakes).

 The only one I didn't apply was

 > Maybe it would make sense to build the SQL string by iterating through
 the different site statuses (you could put those in an array, just like in
 your get_views()).

 That could be good, but it would have beena bit ugly because the first
 selection (where it selects "all") would be an exception; I don't think
 we'll be adding new statuses soon; and IMO leaving it as simple SQL makes
 it easier to immediately understand what it's doing. However, if you feel
 strongly about it, I'm happy to add the loop like you suggested.

 Let me know if I missed something!

 If this looks good, what else is needed to get this ready?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37392#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform