[wp-trac] [WordPress Trac] #43252: Extra tabs when quick editing a comment

WordPress Trac noreply at wordpress.org
Wed Feb 7 21:45:41 UTC 2018


#43252: Extra tabs when quick editing a comment
----------------------------+-------------------------------
 Reporter:  SergeyBiryukov  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.0
Component:  Comments        |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by jrf):

 I agree this should be reverted and shouldn't have been changed in the
 first place, however, it was changed because of an underlying issue, i.e.
 HTML entities not being escaped in the text being passed to the editor.

 IMO, the patch should be updated to properly escape the entities, like
 below:

 {{{
                 <textarea class="comment" rows="1" cols="1"><?php
                         /** This filter is documented in wp-
 admin/includes/comment.php */
                         echo esc_textarea( apply_filters(
 'comment_edit_pre', $comment->comment_content ) );
                 ?></textarea>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43252#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list