[wp-trac] [WordPress Trac] #43226: Crop setting in thumbnails never set when uploading PDF files

[WordPress Trac]

#43226: Crop setting in thumbnails never set when uploading PDF files
------------------------------------------+-----------------------------
 Reporter:  leemon                        |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.9.5
Component:  Media                         |     Version:  4.9.2
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:  administration
------------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  dev-feedback => needs-patch needs-unit-tests
 * milestone:  Awaiting Review => 4.9.5


Comment:

 Hi @leemon, welcome to WordPress Trac! Thanks for the report.

 Yes, the current `! 'thumbnail' === $s` condition doesn't appear to work
 as expected. It's only satisfied if `$s` is boolean false. It should
 indeed be `'thumbnail' !== $s`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43226#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform