[wp-trac] [WordPress Trac] #43235: WP Automatic Updates broken 4.9.3

[WordPress Trac]

#43235: WP Automatic Updates broken 4.9.3
-----------------------------+-----------------------------
 Reporter:  paultgoodchild   |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  4.9.3
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 It seems that a somewhat innocuous quick addition to 4.9.3 has broken WP
 automatic updates for anything except the WordPress core.

 How?

 wp-includes/update.php the following code has been added:

 {{{#!php
 <?php
         // Trigger background updates if running non-interactively, and we
 weren't called from the update handler.
         if ( $doing_cron && $has_auto_update && ! doing_action(
 'wp_maybe_auto_update' ) ) {
                 include_once( ABSPATH . '/wp-admin/includes/update.php' );

                 // Only trigger background updates if an acceptable
 autoupdate is on offer, avoids needless extra API calls.
                 if ( find_core_auto_update() ) {
                         do_action( 'wp_maybe_auto_update' );
                 }
         }
 }}}

 This is plainly wrong, since you're saying: "Only fire automatic updates
 if there are available WP core updates"

 What about plugins and themes?

 Solution is to remove the following check and revert it back to a
 pre-4.9.3 state.
 {{{#!php
 <?php
                 if ( find_core_auto_update() ) { ...
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43235>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform