[wp-trac] [WordPress Trac] #42535: Remove checkered background for icons in Attachment Details

[WordPress Trac]

#42535: Remove checkered background for icons in Attachment Details
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.0
Component:  Media                                |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui,
  testing                                        |  administration
-------------------------------------------------+-------------------------
Changes (by BandonRandon):

 * version:   => 4.9


Comment:

 Hi @janak007 I could be missing something but it looks like your patch is
 always removing the checked background added in #41948.

 The background image itself should remain just be hidden when an icon is
 shown (like with a PDF or video file). This should be what happens when
 you apply
 [https://core.trac.wordpress.org/attachment/ticket/42535/42535.diff
 42535.diff] Could you test to make sure that's happening for you?

 As a small administrative note, when iterating an existing patch to a
 ticket it's generally recommended to add a patch number. For example, your
 patch would be 42535.2.diff. This makes it easy to see the latest patch to
 grab when testing.

 Thanks for contributing to WordPress core :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42535#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform