[wp-trac] [WordPress Trac] #45791: Restore the TinyMCE Help modal keyboard shortcut for the Classic Editor plugin

[WordPress Trac]

#45791: Restore the TinyMCE Help modal keyboard shortcut for the Classic Editor
plugin
---------------------------+-----------------------------
 Reporter:  afercia        |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  TinyMCE        |    Version:  5.0
 Severity:  normal         |   Keywords:  has-screenshots
  Focuses:  accessibility  |
---------------------------+-----------------------------
 [44257] removed the keyboard shortcut to open the TinyMCE help modal. In
 Gutenberg, this shortcut now opens the "global" help modal.

 However, when the Classic Editor plugin is activated, the tooltip still
 displays the keyboard shortcut even if the shortcut doesn't do anything:

 [[Image(http://cldup.com/DGfPkjKNyv.png)]]

 Instead of removing the displayed shortcut from the tooltip, I'd propose
 to restore it only when Classic Editor is used, much like what was done
 for the `access+z` shortcut, see
 https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js?rev=44257#L670.
 This wouldn't affect anything in Gutenberg and seems pretty easy to
 implement.

 Also, worth considering when
 https://github.com/WordPress/gutenberg/issues/6195 will be addressed, the
 shortcut will be displayed also in the tooltip in the Gutenberg Classic
 block. However, it now opens the "global" help modal. Should the passed
 string check for the editor type and display the shortcut conditionally?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45791>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform