[wp-trac] [WordPress Trac] #44458: Catch WSODs and provide a means for recovery for end users
WordPress Trac
noreply at wordpress.org
Sun Dec 23 06:22:52 UTC 2018
#44458: Catch WSODs and provide a means for recovery for end users
-------------------------------------------------+-------------------------
Reporter: schlessera | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 5.1
Component: Bootstrap/Load | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests needs- | Focuses: multisite
testing servehappy |
-------------------------------------------------+-------------------------
Comment (by spacedmonkey):
I have left a couple of comments on the PR [https://github.com/wp-core-php
/wordpress-develop/pull/3/ here].
My biggest issue, the LIKE meta query [https://github.com/wp-core-php
/wordpress-develop/pull/3/files#diff-a08d55fe0e259e54b08e51ef2dea7a7cR177
here]. This is because you store don't store a list of paused plugins, in
site meta as well.
I would store a list of plugins, using the same key but multiple values.
By doing this, you wouldn't have to do a [https://github.com/wp-core-php
/wordpress-develop/pull/3/files#diff-a08d55fe0e259e54b08e51ef2dea7a7cR177
LIKE] or [https://github.com/wp-core-php/wordpress-develop/pull/3/files
#diff-a08d55fe0e259e54b08e51ef2dea7a7cR142 this loop].
The only other major feedback, is site meta check [https://github.com/wp-
core-php/wordpress-develop/pull/3/files#diff-
79ea8a24fbcc66b5d0b4a86aad9036b9R112 here].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44458#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list