[wp-trac] [WordPress Trac] #39521: media_handle_sideload does not initialize the caption/excerpt value

WordPress Trac noreply at wordpress.org
Thu Dec 20 19:21:39 UTC 2018


#39521: media_handle_sideload does not initialize the caption/excerpt value
--------------------------+------------------------------
 Reporter:  dglingren     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  2.6
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Changes (by aaroncampbell):

 * keywords:  has-patch needs-refresh =>


Comment:

 Looking into this it seems like the patch tries to use `$excerpt` which
 doesn't exist inside `media_handle_sideload()`. It also looks like the
 `$content` variable in sideload is the same as the `$excerpt` variable
 `media_handle_upload()`. To bring parity between the two is seems like
 that needs to go into `post_excerpt` and the functionality for filling in
 `$content` needs to be brought over from `media_handle_upload()`.

 Having said all that: I'm not sure of the historical context here or why
 these seem to be treating content/excerpt differently. Some more digging
 is needed, but I'm removing the has-patch tag since the patch here won't
 fix the issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39521#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list