[wp-trac] [WordPress Trac] #44927: Unnecessary is_null() call in get_avatar_data()

WordPress Trac noreply at wordpress.org
Thu Dec 20 02:48:32 UTC 2018


#44927: Unnecessary is_null() call in get_avatar_data()
-------------------------+-----------------------------
 Reporter:  JPry         |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  5.1
Component:  Users        |     Version:
 Severity:  minor        |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:
-------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"44351" 44351]:
 {{{
 #!CommitTicketReference repository="" revision="44351"
 Users: Remove unnecessary `is_null()` call in `get_avatar_data()`.

 The `! is_null()` portion of the condition is unnecessary, because
 `isset()` checks whether a variable is set *and* is not null.

 Props JPry.
 Fixes #44927.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44927#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list