[wp-trac] [WordPress Trac] #45711: Page listing is no longer hierarchical

[WordPress Trac]

#45711: Page listing is no longer hierarchical
-------------------------------+-----------------------------
 Reporter:  david.binda        |       Owner:  desrosj
     Type:  defect (bug)       |      Status:  assigned
 Priority:  normal             |   Milestone:  5.0.2
Component:  Posts, Post Types  |     Version:  trunk
 Severity:  normal             |  Resolution:
 Keywords:  has-patch commit   |     Focuses:  administration
-------------------------------+-----------------------------
Changes (by pento):

 * keywords:  has-patch dev-feedback => has-patch commit
 * owner:  (none) => desrosj
 * status:  new => assigned


Comment:

 Given that `WP_Query` does an `empty()` test on the `orderby` parameter
 ([https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes
 /class-wp-query.php#L2133 ref]), I don't think there's a practical
 difference between the `orderby` parameter not being set, and it being set
 to an empty value.

 Core doesn't call `wp_edit_posts_query()` with the `orderby` parameter set
 to an empty value, so there's no difference to core cause by
 [attachment:"45711.diff"].

 I've had a quick look through the plugins directory, I haven't found any
 `wp_edit_posts_query()` calls that would be affected by this change.

 [attachment:"45711.diff"] is 👍🏻 to commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45711#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform