[wp-trac] [WordPress Trac] #45664: Update `grunt-sass` to v3 and add `node-sass` v4

[WordPress Trac]

#45664: Update `grunt-sass` to v3 and add `node-sass` v4
------------------------------+-------------------------
 Reporter:  netweb            |       Owner:  jeremyfelt
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.1
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch         |     Focuses:
------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * milestone:  5.0.2 => 5.1


Old description:

> Following r44219 with the update of Node.js to v10.13.0 the `grunt-sass`
> package requires an updated binary for the v4.7.2 release for Node.js
> v10.x.
>
> This is not available as `node-sass` v4.7.2 is ~13 months old and
> binaries were never created for this release of Node.js
>
> The solution is to update to a newer version of `node-sass` that includes
> a Node.js 10.x binary, in this case v4.11.0
>
> As `grunt-sass` no longer includes `node-sass` it is also installed and
> the `implementation` option added to the `sass` Grunt task for `grunt-
> sass` v3 compatibility.
>
> See also Core Slack discussion:
> https://wordpress.slack.com/archives/C02RQBWTW/p1544927491907900
>
> Test Pull Request: https://github.com/WordPress/wordpress-develop/pull/34
> Travis CI Build: https://travis-ci.org/WordPress/wordpress-
> develop/builds/468653051
> Travis CI PHP 5.3 Job: https://travis-ci.org/WordPress/wordpress-
> develop/jobs/468653062
> Travis CI PHP 5.2 Job: https://travis-ci.org/WordPress/wordpress-
> develop/jobs/468653063

New description:

 Following r44219 with the update of Node.js to v10.13.0 the `grunt-sass`
 package requires an updated binary for the v4.7.2 release for Node.js
 v10.x.

 This is not available as `node-sass` v4.7.2 is ~13 months old and binaries
 were never created for this release of Node.js

 The solution is to update to a newer version of `node-sass` that includes
 a Node.js 10.x binary, in this case v4.11.0

 As `grunt-sass` no longer includes `node-sass` it is also installed and
 the `implementation` option added to the `sass` Grunt task for `grunt-
 sass` v3 compatibility.

 See also Core Slack discussion:
 https://wordpress.slack.com/archives/C02RQBWTW/p1544927491907900

 * Test Pull Request: https://github.com/WordPress/wordpress-
 develop/pull/34
 * Travis CI Build: https://travis-ci.org/WordPress/wordpress-
 develop/builds/468653051
 * Travis CI PHP 5.3 Job: https://travis-ci.org/WordPress/wordpress-
 develop/jobs/468653062
 * Travis CI PHP 5.2 Job: https://travis-ci.org/WordPress/wordpress-
 develop/jobs/468653063

--

Comment:

 Appears to be an issue in trunk only.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45664#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform