[wp-trac] [WordPress Trac] #45558: Move _draft_or_post_title() from wp-admin/includes to wp-includes

WordPress Trac noreply at wordpress.org
Sun Dec 16 23:26:27 UTC 2018


#45558: Move _draft_or_post_title() from wp-admin/includes to wp-includes
--------------------------+---------------------
 Reporter:  swissspidy    |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0.2
Component:  Editor        |     Version:  5.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by pento):

 I'm a little concerned about moving such an old function.

 Moving it from `wp-admin` to `wp-includes` means it's now defined
 everywhere, there's possibly ancient code that relies on it only being in
 `wp-admin`.

 Moving the file it's in will break any code that specifically loads that
 file, rather than all of WordPress: we ran into this problem a bunch of
 times the last time functions were moved around.

 I'd be more inclined to move `wp_latest_comments_draft_or_post_title()`
 out of the block file, and deprecate `_draft_or_post_title()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45558#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list