[wp-trac] [WordPress Trac] #45643: PHPDoc errors in functions.php

[WordPress Trac]

#45643: PHPDoc errors in functions.php
------------------------------+-----------------------------
 Reporter:  subrataemfluence  |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  5.1
Component:  General           |     Version:  5.0.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  docs
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * focuses:  coding-standards => docs
 * milestone:  Awaiting Review => 5.1


Comment:

 Thanks for the patch!

 `add_query_arg()` arguments are correct, it uses `func_get_args()` to get
 them. The rest looks good.

 In `_xmlrpc_wp_die_handler()`, even though the `$title` argument is not
 used, we cannot remove it. The function signature needs to remain
 consistent with `_default_wp_die_handler()` and `_ajax_wp_die_handler()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45643#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform