[wp-trac] [WordPress Trac] #45641: php7.3 compatibility: "continue" targeting switch is equivalent to "break"

[WordPress Trac]

#45641: php7.3 compatibility: "continue" targeting switch is equivalent to "break"
-------------------------------------+------------------------------
 Reporter:  f0rdprefect              |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  I18N                     |     Version:  5.0.1
 Severity:  normal                   |  Resolution:
 Keywords:  reporter-feedback close  |     Focuses:
-------------------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:   => reporter-feedback close
 * component:  General => I18N


Old description:

> as shown in [0] php7.3 requires different usage of continue in switch
> statements.
> even though [0] is marked as resolved, my wp5.0.1 installation throws
> exactly this error:
> "PHP message: PHP Warning:  "continue" targeting switch is equivalent to
> "break". Did you mean to use "continue 2"? in /wp-includes/pomo/plural-
> forms.php on line 210"
>
> Might have slipped through when adjusting 7.3 compatibility?
>
> [0] https://core.trac.wordpress.org/ticket/44543

New description:

 as shown in #44543 php7.3 requires different usage of continue in switch
 statements.
 even though #44543 is marked as resolved, my wp5.0.1 installation throws
 exactly this error:
 "PHP message: PHP Warning:  "continue" targeting switch is equivalent to
 "break". Did you mean to use "continue 2"? in /wp-includes/pomo/plural-
 forms.php on line 210"

 Might have slipped through when adjusting 7.3 compatibility?

--

Comment:

 Hi @f0rdprefect, welcome to WordPress Trac!

 What does [source:tags/5.0.1/src/wp-includes/pomo/plural-
 forms.php?marks=210#L204 line 210] of `wp-includes/pomo/plural-forms.php`
 look like on your install?

 In WordPress 5.0.1, there's no `continue` operator there. If looks like
 some files in your environment failed to update.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45641#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform