[wp-trac] [WordPress Trac] #45453: Block Editor: Add a Message if JavaScript is disabled

WordPress Trac noreply at wordpress.org
Sat Dec 15 10:00:57 UTC 2018


#45453: Block Editor: Add a Message if JavaScript is disabled
------------------------------------+-----------------------
 Reporter:  mkaz                    |       Owner:  pento
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  5.0.3
Component:  Editor                  |     Version:  5.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------

Comment (by azaozz):

 > Will this filter do the job for the Classic Editor plugin to use?

 Sure. Can replace the text and add a link to the user settings to set
 Classic as default.

 Was wondering if we should also include the screen title there (will add a
 screenshot). Makes it a bit more friendlier.

 While looking at that noticed some inconsistencies with the global
 `$title` in `edit-form-blocks.php`. It resets the $title to Edit Post at
 the top, then never uses it. Then uses
 `$post_type_object->labels->edit_item` in the hidden a11y H1. Fixed that
 in 45453.3.diff to properly display either "Edit Post" or "Add New Post"
 but may be worth a new ticket.

 In 45453.3.diff:
 - Add the screen title when displaying the error message about no js.
 - Fix the global `$title` and use it on the `edit-form-blocks.php`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45453#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list