[wp-trac] [WordPress Trac] #45582: PHP Notice in WP Site Query

[WordPress Trac]

#45582: PHP Notice in WP Site Query
--------------------------------+------------------------
 Reporter:  spacedmonkey        |       Owner:  desrosj
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  5.0.2
Component:  Networks and Sites  |     Version:  4.6
 Severity:  normal              |  Resolution:  fixed
 Keywords:  has-patch php73     |     Focuses:  multisite
--------------------------------+------------------------
Changes (by desrosj):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"44186" 44186]:
 {{{
 #!CommitTicketReference repository="" revision="44186"
 Networks and Sites: Fix incorrect variable location.

 This fixes an issue introduced in [44166] where the `$groupby` variable
 was inserted too low in the `get_site_ids()` function while merging
 [43832] into `trunk`. The merged location did not account for a new
 conditional statement that existed only in `trunk`, and would have
 resulted in values assigned to `$groupby` being erased in certain
 scenarios.

 Props spacedmonkey.

 See #44416.
 Fixes #45582.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45582#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform