[wp-trac] [WordPress Trac] #35667: Maximum execution time error in WP_Text_Diff_Renderer_Table

[WordPress Trac]

#35667: Maximum execution time error in WP_Text_Diff_Renderer_Table
---------------------------------+---------------------
 Reporter:  ocean90              |       Owner:  pento
     Type:  defect (bug)         |      Status:  closed
 Priority:  normal               |   Milestone:  5.0
Component:  Revisions            |     Version:
 Severity:  normal               |  Resolution:  fixed
 Keywords:  has-patch fixed-5.0  |     Focuses:
---------------------------------+---------------------
Changes (by pento):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"44129" 44129]:
 {{{
 #!CommitTicketReference repository="" revision="44129"
 Revisions: Improve performance of `WP_Text_Diff_Renderer_Table`.

 `WP_Text_Diff_Renderer_Table` is used to generate the diff view in
 revisions, but there were some cases that could cause it to take excessive
 amounts of time to run.

 Some noteable cases include:
 - When a large number of new lines were inserted in the middle of the post
 from one revision to the next.
 - When both revisions contain >100 lines.
 - When either revision contains a lot of long lines.

 In one extreme test case, the diff view took over a minute to generate.
 With this change, it now takes less than a second.

 Merges [43775] from the 5.0 branch to trunk.

 Fixes #35667.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35667#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform