[wp-trac] [WordPress Trac] #44664: Twenty Fourteen: Video play icon alignment

[WordPress Trac]

#44664: Twenty Fourteen: Video play icon alignment
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.0.2
Component:  Bundled Theme                        |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-        |     Focuses:  ui
  screenshots needs-testing                      |
-------------------------------------------------+-------------------------
Changes (by laurelfulford):

 * keywords:  good-first-bug has-patch has-screenshots => good-first-bug
     has-patch has-screenshots needs-testing


Comment:

 Thanks for reporting this issue, @celloexpressions, and for the patches,
 @chriseverson and @mmaumio! I'm sorry I couldn't get to this earlier in
 the 5.0 release.

 Reviewing the patches, [attachment:"44664.diff"] looks like it is of a
 different file (package-lock.json) but
 [attachment:"video_icon_alignment.diff"] fixes the issue for me on the
 front-end.

 [attachment:"44664.3.patch"] is basically a copy-paste of that fix into
 the editor styles, so it's fixed there as well. The new block-based editor
 doesn't currently have MediaElement.js enqueued into it, so you can only
 see this issue when using the classic editor. However, these styles are
 also pulled into the block-based editor, so if MediaElement.js is added
 down the road, it should fix it there too.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44664#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform