[wp-trac] [WordPress Trac] #45628: Translator comments showing up incorrectly for certain cases

WordPress Trac noreply at wordpress.org
Thu Dec 13 18:02:46 UTC 2018


#45628: Translator comments showing up incorrectly for certain cases
--------------------------+--------------------------------
 Reporter:  Otto42        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  I18N          |     Version:
 Severity:  normal        |  Resolution:  reported-upstream
 Keywords:                |     Focuses:
--------------------------+--------------------------------

Comment (by garrett-eclipse):

 @ocean90 thanks for the reference I was just taking a look at this.

 I'm curious if in core we add a comment specific to the first string on
 the line if the parser would associate the two strings properly? If so I
 can put a patch in for 5.0.x to address the issue in core.

 Current string;
 `$this->month_abbrev[ /* translators: month name */ __( 'December' ) ]  =
 /* translators: three-letter abbreviation of the month */ _x( 'Dec',
 'December abbreviation' );`

 Suggestion;
 `$this->month_abbrev[ /* translators: month name */ __( 'December' ) ]  =
 /* translators: three-letter abbreviation of the month */ _x( 'Dec',
 'December abbreviation' );`

 Let me know if that mitigates the upstream issue and I'll put a patch
 together.

 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45628#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list