[wp-trac] [WordPress Trac] #45555: Twenty Nineteen: Remove duplicate meta info on single post

[WordPress Trac]

#45555: Twenty Nineteen: Remove duplicate meta info on single post
---------------------------+------------------------------
 Reporter:  pratikkry      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.0
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |     Focuses:
---------------------------+------------------------------
Changes (by subrataemfluence):

 * keywords:   => dev-feedback


Comment:

 I am not sure either if this is a desired behavior, but to me it is a
 welcome behavior, specially for long posts.

 I would however like to suggest the following modification in
 `twentynineteen_entry_footer` in `/var/www/wp-projects/subratasarkar.com
 /wp-content/themes/twentynineteen/inc/template-tags.php` file which will
 allow us to customize the behavior of `entry-footer` as per our need.



 {{{
 <?php
 if ( ! function_exists( 'twentynineteen_entry_footer' ) ) :
    /**
      * Prints HTML with meta information for the categories, tags and
 comments.
      */
    function twentynineteen_entry_footer( $show_post_meta = true ) {

       if( ! $show_post_meta ) return;

       // Hide author, post date, category and tag text for pages.
       if ( 'post' === get_post_type() ) {

          // Posted by
          if( is_array( $show_post_meta ) && ! empty( $show_post_meta ) ) {
             if( true === $show_post_meta['show_author'] ) {
                 twentynineteen_posted_by();
             }
          } else {
             twentynineteen_posted_by();
          }

          // Posted on
          if( is_array( $show_post_meta ) && ! empty( $show_post_meta ) ) {
             if( true === $show_post_meta['posted_on'] ) {
                 twentynineteen_posted_on();
             }
          } else {
             twentynineteen_posted_on();
          }
       }
    }

    ... rest of the code remains intact ...

 endif;
 }}}


 And this is how we can call it:


 {{{
 <footer class="entry-footer">
    <?php
    //$post_meta_options = false;
    $post_meta_options = array(
         'show_author' => false,
         'posted_on'   => false,
    );
    twentynineteen_entry_footer(false);
    ?>
 </footer><!-- .entry-footer -->
 }}}


 `$post_meta_options = false` hides the entire entry footer while


 {{{
 $post_meta_options = array(
    'show_author' => false,
    'posted_on'   => false,
 );
 }}}


 adds the ability to render `Author` and `Posted On` as per requirement.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45555#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform