[wp-trac] [WordPress Trac] #45460: Esacaping suggestion
WordPress Trac
noreply at wordpress.org
Sun Dec 2 12:53:37 UTC 2018
#45460: Esacaping suggestion
-------------------------+----------------------
Reporter: utsav72640 | Owner: (none)
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Users | Version:
Severity: normal | Resolution: wontfix
Keywords: has-patch | Focuses:
-------------------------+----------------------
Changes (by swissspidy):
* status: new => closed
* resolution: => wontfix
* component: General => Users
* milestone: Awaiting Review =>
Comment:
The error messages are just translated strings coming from
`wpmu_activate_signup()`. I don't think there's any point in escaping them
as we trust translations coming from WordPress.org. Also, this would
prevent anyone filtering the messages through `gettext` to include some
HTML if they wanted to.
Two notes on your patch for future reference:
* Please create patches from the base directory of your VCS checkout, so
that it includes the full path to the file `src/wp-activate.php` and not
just `wp-activate.php`
* Please adhere to the [https://make.wordpress.org/core/handbook/best-
practices/coding-standards/php/ WordPress coding standards] and add spaces
between parentheses.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45460#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list