[wp-trac] [WordPress Trac] #44278: Smileys got rendered inside pre/code tags in case html attributes are added to the tag

[WordPress Trac]

#44278: Smileys got rendered inside pre/code tags in case html attributes are added
to the tag
-------------------------------------------------+-------------------------
 Reporter:  Andi Dittrich                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback has-unit-     |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by birgire):

 * keywords:  has-patch dev-feedback needs-unit-tests => has-patch dev-
     feedback has-unit-tests


Comment:

 The patch in [attachment:"44278.3.diff"] includes some suggestions:

 - Adds a unit test for ignored tags with attributes.
 - Uses {{{[^>]*}}} instead of {{{.*}}} with the non-greedy modifier
 {{{U}}}. It feels somewhat more transparent to me.

 Additionally it uses the opportunity to:

 - Add full-stops to inline comments.
 - Capitalize inline comments.
 - Fix a typo in inline comment: From {{{proessing}}} to {{{processing}}}.
 - Format inline description.

 in {{{convert_smilies()}}}.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44278#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform