[wp-trac] [WordPress Trac] #44876: Same url for the Privacy Policy Guide

[WordPress Trac]

#44876: Same url for the Privacy Policy Guide
----------------------------------------+------------------------------
 Reporter:  birgire                     |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  low                         |   Milestone:  Awaiting Review
Component:  Privacy                     |     Version:  4.9.6
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  administration
----------------------------------------+------------------------------
Description changed by birgire:

Old description:

> There are currently two versions of the Privacy Policy Guide url in use:
>
> We have both [https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
> admin/includes/misc.php#L1568 src] +
> [https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
> admin/includes/misc.php#L1388 src]:
>

> {{{
> admin_url( 'tools.php?wp-privacy-policy-guide=1' )
>
> }}}
>
> and ([https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
> admin/privacy.php#L174 src]):
>

> {{{
> admin_url( 'tools.php?wp-privacy-policy-guide' )
>
> }}}
>

> I think we should use the same url for consistency.
>
> This is the check in {{{tool.php}}}
> ([https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
> admin/tools.php#L12 src]):
>
> {{{
> $is_privacy_guide = ( isset( $_GET['wp-privacy-policy-guide'] ) &&
> current_user_can( 'manage_privacy_options' ) );
>
> }}}

New description:

 There are currently two versions of the Privacy Policy Guide url in use:

 We have both [https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
 admin/includes/misc.php#L1568 src] +
 [https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
 admin/includes/misc.php#L1388 src]:

 {{{
 admin_url( 'tools.php?wp-privacy-policy-guide=1' )

 }}}

 and [https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
 admin/privacy.php#L174 src]:


 {{{
 admin_url( 'tools.php?wp-privacy-policy-guide' )

 }}}


 I think we should use the same url for consistency.

 This is the check in {{{tools.php}}}
 ([https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
 admin/tools.php#L12 src]):

 {{{
 $is_privacy_guide = ( isset( $_GET['wp-privacy-policy-guide'] ) &&
 current_user_can( 'manage_privacy_options' ) );

 }}}

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44876#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform