[wp-trac] [WordPress Trac] #44865: class-wp-locale.php has a condition always false

WordPress Trac noreply at wordpress.org
Thu Aug 30 11:48:06 UTC 2018


#44865: class-wp-locale.php has a condition always false
-------------------------+-----------------------------
 Reporter:  naghmesara   |      Owner:  (none)
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  General      |    Version:  4.9.8
 Severity:  normal       |   Keywords:
  Focuses:               |
-------------------------+-----------------------------
 Hi

 in class-wp-locale.php from line 224 to 227 We have defined a condition
 that never runs.

 https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-
 locale.php#L224-L227

 {{{#!php
 <?php
 if ( 'rtl' === $this->text_direction && strpos( get_bloginfo( 'version' ),
 '-src' ) ) {
 }}}

 strpos result always is false because does not have
 get_bloginfo('version') never ever "-src".

 What do you think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44865>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list