[wp-trac] [WordPress Trac] #44838: Self_Link Should Have Echo Option
WordPress Trac
noreply at wordpress.org
Sun Aug 26 13:43:37 UTC 2018
#44838: Self_Link Should Have Echo Option
----------------------------------------+------------------------------
Reporter: dshanske | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Feeds | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch good-first-bug | Focuses:
----------------------------------------+------------------------------
Comment (by dshanske):
@mobeen-abdullah Yours is not a diff.
@jojotjebaby Yours is implemented correctly except for not noting the new
variable is since 4.9.9 or such...
But, in thinking about this after my initial comment, self_link is useful
beyond RSS, which means adding get_self_link without the esc_url makes
sense, as only in the original intent of exporting for RSS feeds should
you need to escape, and adding two variables to change whether it escapes
or not doesn't make sense, so the get function is the better move.
So, self_link would just call get_self_link and echo it with esc_url.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44838#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list