[wp-trac] [WordPress Trac] #44550: The confirmaction page should also be in the user language
WordPress Trac
noreply at wordpress.org
Mon Aug 20 16:34:06 UTC 2018
#44550: The confirmaction page should also be in the user language
-------------------------------------------------+-------------------------
Reporter: birgire | Owner: desrosj
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.9.9
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-screenshots needs-testing has- | Focuses:
patch | administration
-------------------------------------------------+-------------------------
Comment (by garrett-eclipse):
Replying to [comment:7 desrosj]:
> Replying to [comment:6 birgire]:
>
> > An edge cases for 2): A registered user changes to locale Y, after
receiving an email containing the confirmation url with a previous locale
X.
>
> I don't think that can be prevented unless we look up the locale for the
request's user when the page is visited. But because the user would not be
logged in at that point, I don't know that it should.
In this case if the user is logged out we can't determine that they
changed their locale so would make sense to use the locale supplied in the
emailed URL.
Replying to [comment:6 birgire]:
> I've not checked, but wonder if the user from 2) is logged in, if that
should override the wp_lang value in the confirmation url. Maybe it is so?
But as mentioned in the case the user is logged in when they land on the
confirmaction page then a check can be made against their current locale
which I feel makes sense to override the language set on the URL.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44550#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list