[wp-trac] [WordPress Trac] #43731: Use Webpack + NPM scripts to build all the things
WordPress Trac
noreply at wordpress.org
Sun Aug 19 13:32:30 UTC 2018
#43731: Use Webpack + NPM scripts to build all the things
------------------------------+------------------------------
Reporter: omarreiss | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses:
------------------------------+------------------------------
Comment (by omarreiss):
In [changeset:"43577" 43577]:
{{{
#!CommitTicketReference repository="" revision="43577"
General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without
being explicitly assigned to the window. When built with Webpack, the code
gets encapsulated in anonymous functions and those implicit globals get
assigned to the wrong scope. This patch prevents that from happening.
Fixes #44371. See #43731.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43731#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list