[wp-trac] [WordPress Trac] #43749: Update zxcvbn to 4.4.2

[WordPress Trac]

#43749: Update zxcvbn to 4.4.2
-------------------------------------+-------------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  5.0
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by desrosj):

 * milestone:  Future Release => 5.0


Comment:

 @omarreiss Thanks for the update! This is looking good. Checked the
 generated file and it is now appropriate for bedtime story time.

 I am attaching an updated patch that has the following changes:

 - Fixed indentation and alignment, replacing space indentation with tabs.
 - Removing a commented out line in the `rot13:zxcvbn` task.
 - Explicitly adding `wp-includes/js/zxcvbn.min.js` to the list of files to
 minify.

 The resulting `zxcvbn.min.js` file in [attachment:"43749.5.diff"] created
 the file, but did not minify it. This is actually the current behavior in
 core. Instead of adding the file as `zxcvbn.js`, minifying it, and then
 having to add an additional task to remove the`.js` file, the `.min.js`
 file can be specified in the `src` option for the `uglify` task. It does
 have to be listed _after_ the `!**/*.min.js` exclusion, though. Otherwise
 it will not be be processed because the exclusion rule comes after.

 I tested the edit profile screen and the passwords reset screens. Both
 successfully returned expected results in the password strength meter!

 @netweb do you mind giving [attachment:"43749.6.diff"]  a second round of
 testing/review? Otherwise, I think it is good to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43749#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform