[wp-trac] [WordPress Trac] #44600: Update WPCS to 1.0.0, and enforce coding standards

[WordPress Trac]

#44600: Update WPCS to 1.0.0, and enforce coding standards
------------------------------+-------------------------------
 Reporter:  pento             |       Owner:  pento
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  coding-standards
------------------------------+-------------------------------

Comment (by jrf):

 > Cool, let's try and get a release out with the customisations we
 currently have in phpcs.xml.dist.

 For now, that would just mean adding the
 `WordPress.CodeAnalysis.EmptyStatement` sniff to `WordPress-Core` and the
 additional property for the `PEAR.Functions.FunctionCallSignature` sniff.

 All the excludes should stay in the custom ruleset.

 > I don't mind a process where we make tweaks in Core's phpcs.xml.dist,
 then remove them when they're moved to WPCS, instead.

 That's fine by me, but let's make sure that for each tweak in the custom
 ruleset an issue is opened in the WPCS repo to keep WPCS moving along.

 > Is WPCS#1323 sufficient?

 WPCS#1323 actually argues *against* adding the property. It also
 highlights a problem in the documentation generator which needs to be
 fixed (or maybe it has been since ?).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44600#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform