[wp-trac] [WordPress Trac] #44541: Text length should be localizable
WordPress Trac
noreply at wordpress.org
Sat Aug 11 12:41:21 UTC 2018
#44541: Text length should be localizable
--------------------------------------+---------------------
Reporter: miyauchi | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.0
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by birgire):
I wonder if the comment search excerpt and post title, in {{{wp-admin
/edit-comments.php}}}, should be handled here too?
Here are the those two cases:
{{{
wp_html_excerpt( _draft_or_post_title( $post_id ), 50, '…' )
}}}
https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-admin/edit-
comments.php#L207
{{{
wp_html_excerpt( esc_html( wp_unslash( $_REQUEST['s'] ) ), 50, '…'
)
}}}
https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-admin/edit-
comments.php#L220
The current patch also suggests using {{{wp_trim_words()}}} within
{{{get_comment_excerpt()}}}.
Would the context be needed for the {{{wp_trim_words}}} filter, i.e.
''post'' vs ''comment''?
https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-
includes/formatting.php#L3334
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44541#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list