[wp-trac] [WordPress Trac] #44753: Dashboard - Dismiss close button hover effect should be consistent

WordPress Trac noreply at wordpress.org
Sat Aug 11 04:40:20 UTC 2018


#44753: Dashboard - Dismiss close button hover effect should be consistent
-------------------------------------------------+-------------------------
 Reporter:  krupajnanda                          |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Administration                       |     Version:  4.9.8
 Severity:  minor                                |  Resolution:
 Keywords:  ux-feedback has-screenshots has-     |     Focuses:  ui,
  patch                                          |  administration
-------------------------------------------------+-------------------------

Comment (by mukesh27):

 @SergeyBiryukov thank you for your guidance. i know system create min
 version of CSS but for better understanding i have added both file in
 diff. i will take care of it in feature diff.

 Replying to [comment:5 SergeyBiryukov]:
 > Replying to [comment:2 mukesh27]:
 > > @subrataemfluence WordPress deskboar use min version of common css
 file and you have added patch for full version of css file.
 >
 > Actually, minified files should not be patched, they are auto-generated
 by the build tools. There's a
 [http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG
 SCRIPT_DEBUG] constant you can add to your `wp-config.php` file to use
 non-minified files.
 >
 > So [attachment:"44753.diff"] is enough, there's no mistake here.
 However, it would be helpful if the patch was created from the root
 directory and contained the full path: `src/wp-admin/css/common.css`, not
 just `common.css`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44753#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list