[wp-trac] [WordPress Trac] #44550: The confirmaction page should also be in the user language

[WordPress Trac]

#44550: The confirmaction page should also be in the user language
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-testing has-   |     Focuses:
  patch needs-unit-tests                         |  administration
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-screenshots needs-testing has-patch => has-screenshots
     needs-testing has-patch needs-unit-tests


Comment:

 [attachment:"44550.1.diff"] is a different approach that I like better. It
 utilizes code already in `wp-login.php` that detects the `wp_lang` URL
 parameter. This is utilized for all of the other screens (password reset,
 password change, log out, etc.) on `wp-login.php`. It also uses
 `restore_previous_locale()` instead of `restore_current_locale()`. The
 latter restores the original locale and removes any switching history, but
 the former only reverts the most recent switch.

 Tests for this need to be added after or as a part of #43985 (depending
 which is committed first), as that ticket adds tests for the entire
 `wp_send_user_request()` function.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44550#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform