[wp-trac] [WordPress Trac] #43985: Privacy: The user request email should be sent in the user language

[WordPress Trac]

#43985: Privacy: The user request email should be sent in the user language
-------------------------------------------------+-------------------------
 Reporter:  Chouby                               |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  refresh needs-unit-tests                       |  administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing has-unit-tests => has-patch needs-
     testing needs-refresh needs-unit-tests


Comment:

 Hey @desrosj checking 43985.6.diff I found that it's completely missing
 the Unit tests (wpSendUserRequest.php) that were present in 43985.5.diff.

 As well the wp_mail returns a bool only but the wp_send_user_request
 indicates it returns WP_Error|bool; \\
 ` * @return WP_Error|bool Will return true/false based on the success of
 sending the email, or a WP_Error object.` \\
 Should the return approach be updated to match more what's done in
 `wp_privacy_send_personal_data_export_email` here; \\
 https://github.com/WordPress/WordPress/blob/d9df5dec117ca01211c02b90cb88e015e697d68e
 /wp-admin/includes/file.php#L2248
 *Althought maybe instead of just standard 'error' the error code could be
 more specific.

 Cheers

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43985#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform