[wp-trac] [WordPress Trac] #44644: Personal data export request status changed to completed by admin download
WordPress Trac
noreply at wordpress.org
Wed Aug 1 20:25:37 UTC 2018
#44644: Personal data export request status changed to completed by admin download
-------------------------------------+----------------------
Reporter: knutsp | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.9.9
Component: Privacy | Version: 4.9.7
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion | Focuses: privacy
-------------------------------------+----------------------
Changes (by garrett-eclipse):
* milestone: Awaiting Review => 4.9.9
Comment:
Discussing this in Slack and reviewing the issue some more this is quite a
frustrating limitation as in some cases it requires you making a second
confirmation request to restart the workflow.
In the code it seems both the download and email actions trigger the same
ajax workflow but the email has $send_as_email set to true. We should
probably move the _wp_privacy_completed_request() call found in
wp_privacy_process_personal_data_export_page within the conditional `if (
$send_as_email )` here; \\
https://github.com/WordPress/WordPress/blob/d9df5dec117ca01211c02b90cb88e015e697d68e
/wp-admin/includes/file.php#L2369 \\
*This would only trigger the complete when the email is sent
As well to support the case where admin wants to download the export and
craft their own email we should introduce a 'Mark Completed' list action
to the rows that are currently in Confirmed state so they can still push
the request through the workflow but avoid the autogenerated email.
I've marked this for 4.9.9 as it would be nice to rectify this asap
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44644#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list