[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9)
WordPress Trac
noreply at wordpress.org
Mon Apr 30 08:40:45 UTC 2018
#41074: Create new Dashicons (4.9)
---------------------------+------------------------
Reporter: EmpireOfLight | Owner: netweb
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 5.0
Component: Editor | Version: 4.9
Severity: normal | Resolution:
Keywords: needs-refresh | Focuses: ui
---------------------------+------------------------
Comment (by netweb):
Replying to [comment:55 Joen]:
> I think the most important thing to review, though, is the new build
process. Recent work was done in
https://github.com/WordPress/dashicons/pull/246. The build process means
that creating new icons is not an arduous process, which is important so
as to keep the project alive. It comes with only two changes per how it's
been done in the past:
>
> 1. we can't edit `url("...")` to be `url( "..." )` without hacking core
files.
> 2. we can't customize the order of the icons, nor add "grouping"
headers. Icons are output alphabetically
>
> 1 I don't care about, it seems a trivial price to pay for taking the
vinegar and human error aspect out of adding icons. 2 I personally think
is a benefit. But nonetheless these are aspects that should be considered
before switching to the process-built icon font, which I believe still
hasn't happened?
I've just created https://github.com/WordPress/dashicons/pull/298, this PR
updates the CSS template that generates `dashicons.css` to meet WordPress
CSS Coding Standards. As noted in the PR I've added stylelint support so
that it ignores the spacing and quotes around the URLs.
The above makes 1. above no longer a concern once stylelint is added and
2. I'm happy if your happy 🎉
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list