[wp-trac] [WordPress Trac] #43438: Add filters and Ajax support for personal data export

[WordPress Trac]

#43438: Add filters and Ajax support for personal data export
-----------------------------------------------+-----------------------
 Reporter:  azaozz                             |       Owner:  desrosj
     Type:  enhancement                        |      Status:  assigned
 Priority:  normal                             |   Milestone:  4.9.6
Component:  General                            |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  gdpr needs-unit-tests needs-patch  |     Focuses:
-----------------------------------------------+-----------------------

Comment (by desrosj):

 Replying to [comment:34 ocean90]:
 > [42889] has a few issues which need to be addressed:
 >
 > * `wp_ajax_wp_privacy_export_personal_data()` has no DocBlock.

 A DocBlock was added in [43012].

 > * The mbstring PHP extension might be not available, so
 `mb_strtolower()`  needs `function_exists()` check. Note that `is_email()`
 currently doesn't support email addresses with multibyte characters so
 `strtolower()` should be enough.

 The `mb_strtolower()` call was removed in [43012] when the email was
 switched to use the email property of a `WP_User_Request` object. I looked
 at that, though, and it does not seem to account for any multibyte
 characters, so added `strtolower()` back in [attachment:43438.7.diff].

 > * The docs for the `wp_privacy_personal_data_exporters`filter doesn't
 match the [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#1-1-parameters-that-are-arrays docs
 standards].

 Fixed in [attachment:43438.7.diff].

 > * It seems like `$_POST['exporter']` is an numeric index of an exporter.
 Wouldn't it be easier if exporters are referenced by a name instead?

 I agree with this. @allendav, @azaozz any objection? If not, a new ticket
 may be best for this, I think.

 > * What's the idea behind the error messages? Should probably be
 translatable or a code instead.

 Ensured every error message is translatable in [attachment:43438.7.diff].

 > * The nonce check should be enabled.

 Was also addressed in [43012].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43438#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform