[wp-trac] [WordPress Trac] #41858: Improve the list table pagination links color contrast

WordPress Trac noreply at wordpress.org
Sun Apr 29 16:22:15 UTC 2018


#41858: Improve the list table pagination links color contrast
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  afercia
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui,
  dev-note                                       |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots good-first-bug has-patch => has-screenshots
     has-patch needs-dev-note


Comment:

 [attachment:41858.3.diff] cleans up a bit the CSS, also removing old, no
 more used, rules. Final screenshots large screens / responsive view:

 [[Image(https://cldup.com/MP2ezE90bv.png)]]

 [[Image(https://cldup.com/_Dy43RWfbg.png)]]

 I think this change will need a quick dev note post on the Make blog, see
 the edge case on https://core.trac.wordpress.org/ticket/32253#comment:23
 and the screenshots on
 https://core.trac.wordpress.org/ticket/32253#comment:30. See also the test
 plugin uploaded there:
 https://core.trac.wordpress.org/attachment/ticket/32253/paginate-test.php

 Basically, if plugin authors use `paginate_links()` wrapped in some
 containers with the same CSS classes used for the tables navigation links,
 e.g.:

 {{{
 <div class="tablenav">
         <div class="tablenav-pages">
         <?php
                 paginate_links( ... )
         ?>
         </div>
 </div>
 }}}

 The links generated by `paginate_links()` used to inherit the tables
 pagination links styles. I'd tend to think this is an backwards
 compatibility edge case WordPress shouldn't support. The CSS for the
 tables pagination links are specific to the tables and not supposed to be
 reused this way. On the other hand, `paginate_links()` outputs unstyled
 links: styling it's not its responsibility. Plugin authors can provide
 their own style with a few lines of CSS.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41858#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list