[wp-trac] [WordPress Trac] #43436: Add opt-in for commenter cookies

WordPress Trac noreply at wordpress.org
Fri Apr 27 21:06:41 UTC 2018


#43436: Add opt-in for commenter cookies
-------------------------------------------------+-------------------------
 Reporter:  azaozz                               |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.6
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr has-patch 2nd-opinion has-      |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by laurelfulford):

 @xkon I reviewed this update in all of the themes, and it looks good!

 The only thing that stood out to me was in Twenty Fifteen and Twenty
 Sixteen, the default label styles — bold and all-caps — made the checkbox
 labels tricky to read:

 Twenty Fifteen:
 [[Image(https://cldup.com/L4vjllIoS7-3000x3000.png)]]

 Twenty Sixteen:
 [[Image(https://cldup.com/3FBdTnz8VL-3000x3000.png)]]

 Those styles work well for the one-word labels, but they weren’t really
 made for longer strings of text. I tried changing the styles to match the
 `.comment-note` at the top of the form, and I think it helps — for each
 theme, it would look like:

 Twenty Fifteen
 [[Image(https://cldup.com/9ZGNN2OzzH-3000x3000.png)]]

 Twenty Sixteen
 [[Image(https://cldup.com/kvgkTVD6Ot-3000x3000.png)]]

 I’ve updated these styles in [attachment:43436.3.diff] in case anyone else
 finds it’s easier to read. Let me know what you think!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43436#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list