[wp-trac] [WordPress Trac] #43715: Add Privacy Policy link to bundled theme footers

[WordPress Trac]

#43715: Add Privacy Policy link to bundled theme footers
-------------------------------------------------+-------------------------
 Reporter:  xkon                                 |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  gdpr has-patch needs-testing needs-  |     Focuses:  ui
  dev-note                                       |
-------------------------------------------------+-------------------------

Comment (by laurelfulford):

 I discussed possible child theme issues with @davidakennedy. We could
 think of scenarios where the update could cause issues, but we both think
 that they would be minor:

 For example, if someone modified the footer via CSS to add content (like a
 copyright), spacing could be off. Or if they’ve absolutely positioned
 elements in the footer, the new text could result in overlaps or some
 minor visual weirdness once a Privacy Policy page was set.

 As mentioned, there’s also a chance of CSS class name clashes. The styles
 that have been included are well-scoped, though, which should lessen
 interference with other elements in a child theme.

 Any child themes that have very custom footers likely have their own
 footer.php, which won’t include this code until those theme authors add
 it.

 I can’t think of anything else we could do proactively to prevent some
 issues from cropping up, since we can’t really predict what’s been done to
 the themes. But I think the fact the link has to be enabled before
 appearing will help a lot — it won’t suddenly spring up on a bunch of
 sites — and the placement of the link is a really good choice, since it's
 piggybacking off text that's already there :)

 ----

 I also checked over each theme with the latest patch. Overall things are
 looking really good! :) I included some feedback below that is 90%
 nitpicky spacing stuff -- I'm happy to update the patch if these seem like
 reasonable updates:

 **In General**

 We’re using a CSS entity in Twenty Sixteen for the other `/` used in the
 footer (`content:'\002F'`) rather than `content: '/'` — what do you all
 think about using that throughout for consistency?

 **Twenty Ten**

 The spacing seems a little off around the separator (with more on the
 right than left):

 [[Image(https://cldup.com/Jc-L8YsYYU-3000x3000.png)]]

 The CSS is already adjusting a bit for the space (which is coming from a
 line break in the HTML) but I think pushing it a bit further would help.
 Here it is with `padding: 0 0.5em 0 0.3em`

 [[Image(https://cldup.com/mupnR9rn6z-3000x3000.png)]]

 Twenty Ten uses “|” as a separator in other spots in the theme, like the
 post meta. Does it makes sense to use that here as well? It’d look like:

 [[Image(https://cldup.com/61Og3jzqr0-3000x3000.png)]]

 **Twenty Eleven**

 Similar notes about the padding — right now it’s:

 [[Image(https://cldup.com/mEXwCIY3O3-3000x3000.png)]]

 Updating to `padding: 0 0.25em 0 0.5em` turns it into:

 [[Image(https://cldup.com/Re2ew4Agdz-3000x3000.png)]]

 Twenty Eleven also uses “|” in the post meta; if it makes sense to use it
 in the footer as well, it’d look like:

 [[Image(https://cldup.com/Ldb_n-gAca-3000x3000.png)]]

 **Twenty Twelve**

 Similar notes about the padding — right now it’s:

 [[Image(https://cldup.com/PZe_yGr74r-3000x3000.png)]]

 And with `padding: 0 0.3em 0 0.6em` I think it feels a bit more even:

 [[Image(https://cldup.com/bbc873lDsM-3000x3000.png)]]

 **Twenty Thirteen**

 Similar notes about the padding — right now it’s:

 [[Image(https://cldup.com/PepV7UTTju-3000x3000.png)]]

 With `padding: 0 0.25em 0 0.5em `, it looks like:

 [[Image(https://cldup.com/vz_GZWUS1X-3000x3000.png)]]

 **Twenty Fourteen**

 Similar notes about the padding — right now it’s:

 [[Image(https://cldup.com/SUp9maZl5w-3000x3000.png)]]

 With `padding: 0 0.25em 0 0.5em`, it’d look like:

 [[Image(https://cldup.com/HPDMu-F6ut-3000x3000.png)]]

 **Twenty Fifteen**

 Similar notes about the padding — right now it’s:
 [[Image(https://cldup.com/tjdm_ad7xX-3000x3000.png)]]

 With `padding: 0 0.25em 0 0.5em`, it’d look like:

 [[Image(https://cldup.com/cFR8vqMRE9-3000x3000.png)]]

 **Twenty Sixteen**

 The RTL styles for this theme look a bit off. LTR is perfectly spaced:

 [[Image(https://cldup.com/R90ZhoBcc1-3000x3000.png)]]

 The “/“ with the Privacy link includes the font family in the styles, and
 it’s not overwritten in the RTL styles. The original “/“ is actually the
 one that looks off to me in this case (smaller, and misaligned), but they
 should be made to look the same:

 [[Image(https://cldup.com/sKT93vAv2L-3000x3000.png)]]

 **Twenty Seventeen**

 Again, just a small spacing thing - right now it’s:

 [[Image(https://cldup.com/rHKJ53sA8o-3000x3000.png)]]

 With `padding: 0 0.2em 0 0.4em`, it would look like:

 [[Image(https://cldup.com/5FtL4hYUCm-3000x3000.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43715#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform