[wp-trac] [WordPress Trac] #43850: Add privacy policy URL template tags

[WordPress Trac]

#43850: Add privacy policy URL template tags
------------------------------------------+--------------------------------
 Reporter:  iandunn                       |       Owner:  iandunn
     Type:  enhancement                   |      Status:  assigned
 Priority:  normal                        |   Milestone:  4.9.6
Component:  General                       |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr needs-testing has-patch  |     Focuses:  ui,
                                          |  administration
------------------------------------------+--------------------------------

Comment (by iandunn):

 Replying to [comment:4 birgire]:
 > - Change {{{Tests_Link_GetPrivacyPolicyUrl()}}} to
 {{{Tests_Url_GetPrivacyPolicyUrl()}}}.

 Good catch :)

 > - The tag {{{@subpackage}}} seems to be on it's way out

 Ah, I hadn't seen that, thanks for pointing it out. It sounds like we're
 keeping `@subpackage` for the mean time, though?

   For the time being, and for the sake of consistency, WordPress Core will
 continue to use @subpackage tags – both when writing new DocBlocks, and
 editing old ones.[[br]][[br]]
   Only when the new – external – PSR-5 recommendations are finalized, will
 across-the-board changes be considered, such as deprecating certain tags.

 > - The cleanup must come before assertions, else the cleanup might not
 run on a failure. We should remove the filter callbacks before the
 assertion.

 I think [https://make.wordpress.org/core/handbook/testing/automated-
 testing/writing-phpunit-tests/#globals hook callbacks are automatically
 removed after each test is ran], regardless of the assertions:

   ...all actions and filters are reset to their original state after each
 test as well, so it is not necessary to manually remove hooks that have
 been added in a test.

 That works in my tests. So technically, we don't even need to call
 `remove_filter()`, since there aren't any assertions after it, but it
 still seems good to include it, just to be explicit and avoid future
 problems if more assertions are added.

 > - Add a parameter comment here:
 > - Add member variable doc comments here:

 Done, thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43850#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform