[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions

[WordPress Trac]

#41191: Create browse happy type notice for PHP versions
-------------------------------------------------+-------------------------
 Reporter:  joostdevalk                          |       Owner:  flixos90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ui-feedback needs-testing  |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by johnjamesjacoby):

 @flixos90 @SergeyBiryukov

 > We can have the best out of both worlds...

 That's not a bad idea. I don't like having HTML in the string, but that's
 not new.

 In retrospect, this shouldn't even be styled as a button; it doesn't
 submit anything, and it's an external link. What if we take inspiration
 from the Events and News meta-box and make it a link at the very bottom?

 All of the other "Learn more about..." links in core are not buttons.

 > While it is terrible we need to hack to accomplish that, this indicates
 a lack of flexibility in the Meta Boxes API.

 These are the kind of code compromises we make to support backwards
 compatibility, not introduce a new feature.

 No. The meta-box API intentionally prevents unique boxes because they
 break the promise we make to users about how meta-boxes work. The reason
 BrowseHappy & ServeHappy need special casing is because they're ignoring
 that promise. If a plugin asked for special casing like this, we'd be
 trying to convince them why it's not necessary.

 If core needs unique meta-box types, then we should build that before
 this. There are 3 right now in core alone: Welcome, BrowseHappy, and this
 one. That feature is literally a separate issue from this one.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:109>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform