[wp-trac] [WordPress Trac] #43632: Add a musical note symbol to Hello Dolly lyrics

WordPress Trac noreply at wordpress.org
Tue Apr 24 02:41:05 UTC 2018


#43632: Add a musical note symbol to Hello Dolly lyrics
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.6
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch ui-        |     Focuses:
  feedback                                       |  accessibility
-------------------------------------------------+-------------------------

Comment (by desrosj):

 I tried testing this with VoiceOver in Chrome, but I was unable to use the
 keyboard to actually navigate to the lyrics. I am a novice when it comes
 to testing with VoiceOver, though, so I could be missing something.

 That aside, the patch looks good, but I have a few things that I noticed.

 - On mobile, the lyric gets a little cramped ([attachment:plugin-on-
 cramped.png]). When the plugin is off, the Add New button is pulled up and
 it feels fine ([attachment:plugin-off.png]), but I find myself wanting the
 height of the lyric to be similar to the Screen Options height, or at
 least have some bottom padding.
 - The baseline for the lyric is also slightly off from the screen options
 tab and feels off to me.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43632#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list