[wp-trac] [WordPress Trac] #43620: Privacy Policy page design

[WordPress Trac]

#43620: Privacy Policy page design
------------------------------------------+--------------------------------
 Reporter:  melchoyce                     |       Owner:  xkon
     Type:  enhancement                   |      Status:  assigned
 Priority:  normal                        |   Milestone:  4.9.6
Component:  General                       |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  gdpr has-patch needs-testing  |     Focuses:  ui,
                                          |  administration
------------------------------------------+--------------------------------

Comment (by iandunn):

 [attachment:43620.policy_url.policy_link_3.diff] has a few iterations on
 the URL/link functions:

 * Typecast `get_permalink()` result to a string, to ensure a consistent
 return type.
 * Adds a separate `echo` function, instead of an `$echo = true` param.
 This is kind of subjective; both patterns exist in Core. To me, the former
 feels slightly more convenient for devs, and a bit more straightforward
 for both humans and linting tools. The function and filter names were
 updated as a result.
 * Minor alignment/standards/line wrapping/etc tweaks.

 Does anyone have any feedback on that? If not, I think it's ready for
 commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43620#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform