[wp-trac] [WordPress Trac] #43620: Privacy Policy page design
WordPress Trac
noreply at wordpress.org
Sat Apr 21 11:24:26 UTC 2018
#43620: Privacy Policy page design
------------------------------------------+--------------------------------
Reporter: melchoyce | Owner: xkon
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.9.6
Component: General | Version:
Severity: normal | Resolution:
Keywords: gdpr has-patch needs-testing | Focuses: ui,
| administration
------------------------------------------+--------------------------------
Comment (by birgire):
Replying to [comment:33 xkon]:
> After going through all the themes in #43715 and re-checking the
comments here ( was kinda late! ) I thought of taking a shot at what
@azaozz proposed so, made [attachment:43620.policy_url.policy_link.diff]
that extends on [attachment:43620-url-filter.diff] just in case I have it
right.
>
That looks good, I would though not name the function with {{{get_*()}}}
if it will echo the output and not return it.
Sometimes there's {{{$echo = true}}} input argument, like we see in
{{{edit_term_link()}}}.
> This way I could go back into the themes and change everything basically
to `get_privacy_policy_link( '<span class="privacy-link-wrapper">',
'</span>' );` if I'm correct :D
I noticed that the a tag already has {{{class="privacy-link-wrapper"}}}, I
then wonder if the span is needed?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43620#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list