[wp-trac] [WordPress Trac] #43813: Meta API should set `last_changed` cache key internally

WordPress Trac noreply at wordpress.org
Fri Apr 20 08:15:42 UTC 2018


#43813: Meta API should set `last_changed` cache key internally
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:  (none)
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  General          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------------------
Changes (by flixos90):

 * type:  defect (bug) => enhancement


Comment:

 While I'm generally in favor of this change, I think we might wanna hold
 off this for a bit. Something to consider here is that moving this logic
 into the actual metadata API functions will make it harder to make
 adjustments specific to only a subset of these object types - which is
 generally nothing we should strive for, but something that may be
 necessary sometimes.

 * For example experimenting with a meta-related caching improvement should
 rather happen on a less-used component like site meta first before
 shooting it out there to be used with posts, terms etc immediately.
 * Another example is that user meta right now does not invalidate cache on
 meta changes - which may have a background, I'm not sure. Just
 highlighting this as another example where all object types
 (unfortunately) are not the same.

 A specific idea I had in mind was to introduce meta-specific last changed
 keys for every object type (see #43818), to make cache invalidation less
 aggressive which would result in less unnecessary cache misses for queries
 not using any metadata. Something like this I think should rather be
 tested with something like site meta before applying it to the really
 frequently used post meta - just so that we can detect most basic issues
 (if any) immediately before testing it under heavier load.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43813#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list