[wp-trac] [WordPress Trac] #43583: Introduce new PHP cross-version compat function `is_countable()`
WordPress Trac
noreply at wordpress.org
Thu Apr 19 20:57:45 UTC 2018
#43583: Introduce new PHP cross-version compat function `is_countable()`
--------------------------------------+---------------------
Reporter: jrf | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 4.9.6
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by desrosj):
This is looking good to me. I made a few adjustments in
[attachment:43583.patch]:
- Combined the two patches above into one patch.
- Switched to brackets instead of the alternative syntax.
- Added `@since` tag to the inline documentation.
- Added the `@ticket` tag to the unit test inline documentation.
- Changed booleans in the documentation to lowercase to match core.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43583#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list